Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Some Missing Accessible Names for Input Elements #33714

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Fix Some Missing Accessible Names for Input Elements #33714

merged 1 commit into from
Sep 26, 2024

Conversation

Grunet
Copy link
Contributor

@Grunet Grunet commented Sep 25, 2024 •
edited by github-actions bot
Loading

These are just the ones I noticed from a quick search, I'm guessing there are others still around.

I picked the label wrapping approach for giving the inputs their accessible names because I saw other places in the code doing that.

Is there some kind of linter or unit test tool for cshtml files that could surface these more easily? (like axe linter) Just curious

Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/components/class-libraries-and-static-server-side-rendering.md ASP.NET Core Razor class libraries (RCLs) with static server-side rendering (static SSR)
aspnetcore/mvc/models/model-binding.md Model Binding in ASP.NET Core
aspnetcore/mvc/views/razor.md Razor syntax reference for ASP.NET Core
aspnetcore/mvc/views/working-with-forms.md aspnetcore/mvc/views/working-with-forms
aspnetcore/release-notes/aspnetcore-5.0.md What's new in ASP.NET Core 5.0

@Grunet
Copy link
Contributor Author

Grunet commented Sep 25, 2024

@dotnet-policy-service agree

@guardrex
Copy link
Collaborator

guardrex commented Sep 25, 2024 •
edited
Loading

Thanks @Grunet ... I'm ok with the Blazor update.

Note for future reference that we ask for an issue prior to submitting work for anything other than small patch changes.

BTW ... Blazor forms work is tracked by an existing work item, and I'll be making this change and several others together. If you perform any further updates on the repo in this vein, filter out the Blazor articles (blazor folder) to avoid updates to them.

@Grunet
Copy link
Contributor Author

Grunet commented Sep 25, 2024

Thanks @Grunet ... I'm ok with the Blazor update.

Note for future reference that we ask for an issue prior to submitting work for anything other than small patch changes.

BTW ... Blazor forms work is tracked by an existing work item, and I'll be making this change and several others together. If you perform any further updates on the repo in this vein, filter out the Blazor articles (blazor folder) to avoid updates to them.

Ah got it sorry about that! I was initially planning on just addressing the 1 spot I originally noticed but then I noticed other spots had it too and got carried away...

wadepickett
wadepickett approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@wadepickett wadepickett left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked through the content to see if we happen to reference a line in a way that would need to change to sync with the addition of <label></label>. I didn't find any.

Looks good. @Grunet, thanks very much for this contribution, greatly appreciated!

@wadepickett wadepickett merged commit bc52fc0 into dotnet:main Sep 26, 2024
3 checks passed
@Grunet Grunet deleted the fix-name-labels branch September 26, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guardrex guardrex guardrex approved these changes

@wadepickett wadepickett wadepickett approved these changes

@Rick-Anderson Rick-Anderson Awaiting requested review from Rick-Anderson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Grunet @guardrex @wadepickett